Application adding bugfix; consolidated Settings headers

src/pages/settings/components/Applications/Applications.tsx

@@ -7,7 +7,6 @@ import {
 	Grid,
 	GridCol,
 	Group,
-	Modal,
 	Popover,
 	Stack,
 	Text,
@@ -16,21 +15,15 @@ import {
 import { useDebouncedValue, useDisclosure } from '@mantine/hooks';
 import { useCommonHooks, useMutationAPI, useQueryAPI } from 'hooks';
 import { useEffect, useState } from 'react';
-import { cardClasses, modalClasses, textInputClasses } from 'styles';
+import { textInputClasses } from 'styles';
 import type { Application } from 'types';
+import AddItemModal from '../Shared/AddItemModal';
 import SettingsHeader from '../Shared/SettingsHeader';
 import AppSettingsItem from './AppSettingsItem';
 import DebouncedApplication from './DebouncedApplication';
 
 const ApplicationSettings = () => {
-	const endpoint = 'api/apps';
-	const { data: apps, isFetching: isAppsFetching } = useQueryAPI({
-		endpoint: endpoint,
-	});
-	const [applicationData, setApplicationData] = useState<Application[]>([]);
-	const [applicationList, setApplicationList] = useState<Application[]>([]);
-	const { theme, isMobile, modalStyle } = useCommonHooks();
-	const [newApplication, setNewApplication] = useState<Application>({
+	const defaultApplication: Application = {
 		id: null,
 		name: '',
 		url: '',
@@ -39,7 +32,16 @@ const ApplicationSettings = () => {
 		filterName: '',
 		index: 0,
 		enabled: 1,
+	};
+	const appsEndpoint = 'api/apps';
+	const appsOrderEndpoint = 'api/appsOrder';
+	const { data: apps, isFetching: isAppsFetching } = useQueryAPI({
+		endpoint: appsEndpoint,
 	});
+	const [applicationData, setApplicationData] = useState<Application[]>([]);
+	const [applicationList, setApplicationList] = useState<Application[]>([]);
+	const { theme, isMobile } = useCommonHooks();
+	const [newApplication, setNewApplication] = useState<Application>(defaultApplication);
 	const { mutateAsync } = useMutationAPI();
 	const [searchValue, setSearchValue] = useState('');
 	const [debouncedSearch] = useDebouncedValue(searchValue, 500);
@@ -74,6 +76,11 @@ const ApplicationSettings = () => {
 
 	const [modalOpened, { open: openModal, close: closeModal }] = useDisclosure(false);
 
+	const handleClose = () => {
+		closeModal();
+		setNewApplication(defaultApplication);
+	};
+
 	useEffect(() => {
 		if (apps && !isAppsFetching) {
 			setApplicationData(
@@ -90,7 +97,7 @@ const ApplicationSettings = () => {
 		if (applicationList.length > 0 && applicationList !== applicationData) {
 			mutateAsync({
 				method: 'PATCH',
-				endpoint: 'api/applicationOrder',
+				endpoint: appsOrderEndpoint,
 				body: applicationList,
 			});
 		}
@@ -98,134 +105,116 @@ const ApplicationSettings = () => {
 
 	return (
 		<Stack w={'100%'}>
-			<Modal.Root
-				size={'60%'}
-				className={modalClasses.helpModal}
-				classNames={modalClasses}
-				opened={modalOpened}
-				fullScreen={isMobile}
-				onClose={() => {
-					closeModal();
-				}}
-				style={modalStyle}
-				closeOnEscape
-				closeOnClickOutside
-			>
-				<Modal.Overlay />
-				<Modal.Content>
-					<Modal.Header>
-						<Modal.Title>Add a new application</Modal.Title>
-						<Modal.CloseButton />
-					</Modal.Header>
-					<Modal.Body pb={'2rem'}>
-						<Card className={cardClasses.settingsItem} classNames={cardClasses}>
-							<Stack gap={0} align='center'>
-								<Group justify='center'>
-									<TextInput
-										label={'Name'}
-										className={textInputClasses.settingsItem}
-										pt={16}
-										classNames={textInputClasses}
-										defaultValue={newApplication.name}
-										onChange={(event) => {
-											setNewApplication({
-												...newApplication,
-												name: event.target.value,
-											});
-										}}
-									/>
-									<TextInput
-										label={'Base URL'}
-										className={textInputClasses.settingsItem}
-										pt={16}
-										classNames={textInputClasses}
-										defaultValue={newApplication.baseUrl}
-										onChange={(event) => {
-											setNewApplication({
-												...newApplication,
-												baseUrl: event.target.value,
-											});
-										}}
-									/>
-								</Group>
-								<Group w={isMobile ? undefined : '60%'} justify='center'>
-									<TextInput
-										label={'URL'}
-										className={textInputClasses.settingsItem}
-										pt={16}
-										w={isMobile ? undefined : '91%'}
-										classNames={textInputClasses}
-										defaultValue={newApplication.url}
-										onChange={(event) => {
-											setNewApplication({
-												...newApplication,
-												url: event.target.value,
-											});
-										}}
-									/>
-								</Group>
-								<Group justify='center'>
-									<TextInput
-										label={'Icon'}
-										className={textInputClasses.settingsItem}
-										pt={16}
-										classNames={textInputClasses}
-										defaultValue={newApplication.icon}
-										onChange={(event) => {
-											setNewApplication({
-												...newApplication,
-												icon: event.target.value,
-											});
-										}}
-									/>
-									<TextInput
-										label={'Filter'}
-										className={textInputClasses.settingsItem}
-										pt={16}
-										classNames={textInputClasses}
-										defaultValue={newApplication.filterName}
-										onChange={(event) => {
-											setNewApplication({
-												...newApplication,
-												filterName: event.target.value,
-											});
-										}}
-									/>
-								</Group>
+			<AddItemModal
+				modalOpened={modalOpened}
+				handleClose={handleClose}
+				title={'Add a new application'}
+				body={
+					<Stack gap={0} align='center'>
+						<Group justify='center'>
+							<TextInput
+								label={'Name'}
+								className={textInputClasses.settingsItem}
+								pt={16}
+								classNames={textInputClasses}
+								defaultValue={newApplication.name}
+								onChange={(event) => {
+									setNewApplication({
+										...newApplication,
+										name: event.target.value,
+									});
+								}}
+							/>
+							<TextInput
+								label={'Base URL'}
+								className={textInputClasses.settingsItem}
+								pt={16}
+								classNames={textInputClasses}
+								defaultValue={newApplication.baseUrl}
+								onChange={(event) => {
+									setNewApplication({
+										...newApplication,
+										baseUrl: event.target.value,
+									});
+								}}
+							/>
+						</Group>
+						<Group w={isMobile ? undefined : '60%'} justify='center'>
+							<TextInput
+								label={'URL'}
+								className={textInputClasses.settingsItem}
+								pt={16}
+								w={isMobile ? undefined : '91%'}
+								classNames={textInputClasses}
+								defaultValue={newApplication.url}
+								onChange={(event) => {
+									setNewApplication({
+										...newApplication,
+										url: event.target.value,
+									});
+								}}
+							/>
+						</Group>
+						<Group justify='center'>
+							<TextInput
+								label={'Icon'}
+								className={textInputClasses.settingsItem}
+								pt={16}
+								classNames={textInputClasses}
+								defaultValue={newApplication.icon}
+								onChange={(event) => {
+									setNewApplication({
+										...newApplication,
+										icon: event.target.value,
+									});
+								}}
+							/>
+							<TextInput
+								label={'Filter'}
+								className={textInputClasses.settingsItem}
+								pt={16}
+								classNames={textInputClasses}
+								defaultValue={newApplication.filterName}
+								onChange={(event) => {
+									setNewApplication({
+										...newApplication,
+										filterName: event.target.value,
+									});
+								}}
+							/>
+						</Group>
 
-								<Divider color='black' my='lg' />
-								<Group pos={'absolute'} bottom={8}>
-									<Button
-										color={'green'}
-										styles={{ label: { color: 'black' } }}
-										onClick={() => {
-											if (newApplication) {
-												mutateAsync({
-													method: 'POST',
-													endpoint: endpoint,
-													body: newApplication,
-												});
-												closeModal();
-											}
-										}}
-									>
-										Save
-									</Button>
-									<Button
-										color={'red'}
-										styles={{ label: { color: 'black' } }}
-										onClick={() => {
-											closeModal();
-										}}
-									>
-										Cancel
-									</Button>
-								</Group>
-							</Stack>
-						</Card>
-					</Modal.Body>
-				</Modal.Content>
-			</Modal.Root>
+						<Divider color='black' my='lg' />
+						<Group pos={'absolute'} bottom={8}>
+							<Button
+								color={'green'}
+								styles={{ label: { color: 'black' } }}
+								onClick={() => {
+									if (newApplication) {
+										mutateAsync({
+											method: 'POST',
+											endpoint: appsEndpoint,
+											body: {
+												...newApplication,
+												index: applicationData.length,
+											},
+										}).then(handleClose);
+									}
+								}}
+							>
+								Save
+							</Button>
+							<Button
+								color={'red'}
+								styles={{ label: { color: 'black' } }}
+								onClick={handleClose}
+							>
+								Cancel
+							</Button>
+						</Group>
+					</Stack>
+				}
+			/>
 			<SettingsHeader
 				setDragging={setDragging}
 				openModal={openModal}